Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parse flags before logging #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: parse flags before logging #46

wants to merge 1 commit into from

Conversation

uhthomas
Copy link

@uhthomas uhthomas commented Oct 11, 2023 •
edited
Loading

glog never has the opportunity to read the given flags, and will therefore create a temporary log file even if explicitly disabled.

Fixes: #45

@uhthomas
fix: parse flags before logging
8acb5fc 
glog never has the opportunity to read the given flags, and will therefore
create a temporary log file even if explicitly disabled.

Fixes: 1Password#45
@uhthomas
Copy link
Author

Would you mind taking a look at this?

@edif2008 @volodymyrZotov @jillianwilson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash with read-only root filesystem
1 participant
@uhthomas