Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up, modernize, and release pymdgen #22

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Clean up, modernize, and release pymdgen #22

merged 3 commits into from
Nov 12, 2024

Conversation

vegu
Copy link

@vegu vegu commented Nov 11, 2024

  • migrate poetry to uv

  • update unit test

  • fix review

* migrate poetry to uv

* update unit test

* fix review
@vegu
Copy link
Author

vegu commented Nov 11, 2024

Replaces #21 including codecov fixes

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 61.23%. Comparing base (4a1bac8) to head (7679ab7).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
src/pymdgen/test_getargspec.py 0.00% 2 Missing ⚠️
src/pymdgen/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #22       +/-   ##
===========================================
- Coverage   88.53%   61.23%   -27.31%     
===========================================
  Files           4        5        +1     
  Lines         253      276       +23     
===========================================
- Hits          224      169       -55     
- Misses         29      107       +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vegu vegu merged commit b789d41 into master Nov 12, 2024
23 of 24 checks passed
@vegu vegu linked an issue Nov 12, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix issues with python 3.11
2 participants