Skip to content

Commit

Permalink
Make sure binderhub-service is dissabled by default
Browse files Browse the repository at this point in the history
  • Loading branch information
GeorgianaElena committed Jul 17, 2023
1 parent 4cc9d0d commit c578f90
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 0 deletions.
8 changes: 8 additions & 0 deletions helm-charts/basehub/values.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,14 @@ properties:
binderhub-service:
type: object
additionalProperties: true
required:
- enabled
properties:
enabled:
type: boolean
# https://github.com/2i2c-org/binderhub-service
description: |
Enable image building with binderhub-service
# jupyterhub is a dependent helm chart and we rely _mostly_ on its schema
# validation for values passed to it and are not imposing restrictions on
# most of them in this helm chart.
Expand Down
3 changes: 3 additions & 0 deletions helm-charts/basehub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ userServiceAccount:
enabled: true
annotations: {}

binderhub-service:
enabled: false

ingressBasicAuth:
enabled: false
# Primarily here for validation to 'work',
Expand Down

0 comments on commit c578f90

Please sign in to comment.