chore: Remove default getSearchParamsSnapshot

47ng · Dec 17, 2024 · c35fb8c · c35fb8c
1 parent 2485852
commit c35fb8c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/packages/nuqs/src/adapters/lib/react-router.ts b/packages/nuqs/src/adapters/lib/react-router.ts
@@ -14,7 +14,7 @@ import {
   type SearchParamsSyncEmitter
 } from './patch-history'
 
-// Abstract the types for the useNavigate hook from react-router-based frameworks
+// Abstract away the types for the useNavigate hook from react-router-based frameworks
 type NavigateUrl = {
   hash?: string
   search?: string
@@ -30,10 +30,6 @@ type UseSearchParams = () => [URLSearchParams, {}]
 
 // --
 
-function getSearchParamsSnapshot() {
-  return new URLSearchParams(location.search)
-}
-
 export function createReactRouterBasedAdapter(
   adapter: string,
   useNavigate: UseNavigate,
@@ -82,8 +78,7 @@ export function createReactRouterBasedAdapter(
     )
     return {
       searchParams,
-      updateUrl,
-      getSearchParamsSnapshot
+      updateUrl
     }
   }
   function useOptimisticSearchParams() {

diff --git a/packages/nuqs/src/update-queue.ts b/packages/nuqs/src/update-queue.ts
@@ -66,6 +66,10 @@ export function enqueueQueryStringUpdate<Value>(
   return serializedOrNull
 }
 
+function getSearchParamsSnapshotFromLocation() {
+  return new URLSearchParams(location.search)
+}
+
 /**
  * Eventually flush the update queue to the URL query string.
  *
@@ -77,7 +81,7 @@ export function enqueueQueryStringUpdate<Value>(
  * @returns a Promise to the URLSearchParams that have been applied.
  */
 export function scheduleFlushToURL({
-  getSearchParamsSnapshot = () => new URLSearchParams(location.search),
+  getSearchParamsSnapshot = getSearchParamsSnapshotFromLocation,
   updateUrl,
   rateLimitFactor = 1
 }: Pick<