Headers row sort -> literal buttons instead of icon with onClick handler #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change icon into a button
alexkb0009
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent is to change the dropdown icons in search result table headers to be actual buttons for accessibility. However is very low priority.
Current issue is using tab navigation on header row icons/buttons will cause the header to scroll and lose alignment with the columns. When use tab navigation on search results columns, this issue isn't present, because we have onScroll handlers on the search result table body. Might be worth looking into to detect movements of header and then align body to it, but could be slightly challenging/complex to implement (need to prevent handlers from interfering w. each other) and ultimately probably not worth the effort to do...
Another issue is we render the 'dropdown menu' at different place in DOM than the header, because header row is wrapped a 'no overflow' container and thus the dropdown would be snipped off. So can't tab-navigate between header items and dropdown menu items (i.e. to cancel selection of sort option) at moment.
For now, won't spend time on this.