Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Metadata issues in v1.0.0b2 #286

Closed
marc-white opened this issue Dec 3, 2024 · 3 comments · Fixed by #287
Closed

[BUG] Metadata issues in v1.0.0b2 #286

marc-white opened this issue Dec 3, 2024 · 3 comments · Fixed by #287
Assignees
Labels
bug Something isn't working

Comments

@marc-white
Copy link
Collaborator

Describe the bug

There are other metadata issues in the v1.0.0b2 release that need fixing. This is a catch-all ticket for tracking them.

To Reproduce

Attempt a catalog build using v1.0.0b2.

@marc-white
Copy link
Collaborator Author

Of the metadata.yaml stored in config/metadata_sources, the following fail validation:

era5-rt52

Validating config/metadata_sources/era5-rt52/metadata.yaml... 

VALIDATION FAILED:

01 | reference : ['https://rmets.onlinelibrary.wiley.com/doi/10.1002/qj.3803', 'https://rmets.onlinelibrary.wiley.com/doi/10.1002/qj.4174', 'https://www.ecmwf.int/en/elibrary/81149-global-stratospheric-temperature-bias-and-other-stratospheric-aspects-era5-and', 'https://www.ecmwf.int/en/elibrary/19911-low-frequency-variability-and-trends-surface-air-temperature-and-humidity-era5-and', 'https://www.ecmwf.int/en/publications/search?searc_all_field=era5'] is not of type 'string', 'null'
02 | related_experiments : None is not of type 'array'
03 | keywords : None is not of type 'array'

narclim2-zz63

The metadata-validate script fails completely, due to the mixing of 'long string' and 'array' types in the reference field. Once that is cleared:

Validating config/metadata_sources/narclim2-zz63/metadata.yaml... 

VALIDATION FAILED:

01 | frequency : 'mon' is not valid under any of the given schemas
02 | frequency : 'day' is not valid under any of the given schemas
03 | reference : ['https://doi.org/10.1029/2021EF002625', 'https://doi.org/10.5194/gmd-2024-41', 'https://doi.org/10.5194/gmd-2024-87'] is not of type 'string', 'null'
04 | related_experiments : None is not of type 'array'

I will fix era5 on this branch, and @charles-turner-1 can transfer it into the live location on xp65. I understand he has already made a fix to narclim2 on the live, so I will cross-deck the changes from there.

@marc-white marc-white self-assigned this Dec 3, 2024
@marc-white marc-white linked a pull request Dec 3, 2024 that will close this issue
@charles-turner-1
Copy link
Collaborator

Have already fixed this in /g/data/xp65/admin/intake/metadata/rcm_ccam_hq89

$ cd /g/data/xp65/admin/intake/metadata/rcm_ccam_hq89
$ metadata-validate metadata.yaml
$ Validating metadata.yaml...

VALIDATION FAILED:

01 | frequency : 'day' is not valid under any of the given schemas
02 | frequency : 'mon' is not valid under any of the given schemas

@charles-turner-1
Copy link
Collaborator

Turned out to already have been corrected in the package config/metadata_sources/rcm-ccam-hq89/metadata.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants