Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metadata bugs in ERA5, Narclim #287

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

marc-white
Copy link
Collaborator

Fixes #286.

This PR contains metadata format fixes for the experiments era5-rt52 and narclim2-zz63.

@charles-turner-1 before approving the PR and merging, you'll need to copy both of the new files over to the live location on xp65 (I found a stray comma in the narclim keywords list that I dealt with).

@marc-white marc-white linked an issue Dec 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.44%. Comparing base (9d540e2) to head (67db84e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #287   +/-   ##
=======================================
  Coverage   98.44%   98.44%           
=======================================
  Files          11       11           
  Lines         838      838           
=======================================
  Hits          825      825           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@charles-turner-1 charles-turner-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed a commit including an update to the short description on NARCliM too - mirroring the xp65 version.

@charles-turner-1 charles-turner-1 merged commit f7cfc72 into main Dec 3, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] Metadata issues in v1.0.0b2
2 participants