Implement ledgers deposit rest api #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elwizzy12
requested review from
francis-pouatcha,
Arielpetit,
NkwaTambe,
Koufan-De-King and
nancymuyeh
NkwaTambe
reviewed
Oct 2, 2024
ledgers-deposit-account/ledgers-deposit-account-service-api/pom.xml
Outdated
Show resolved
Hide resolved
Arielpetit
requested changes
Oct 3, 2024
...count-service-api/src/main/java/de/adorsys/ledgers/deposit/api/domain/payment/PaymentTO.java
Outdated
Show resolved
Hide resolved
...service-api/src/main/java/de/adorsys/ledgers/deposit/api/domain/payment/PaymentTargetTO.java
Outdated
Show resolved
Hide resolved
...count-service-api/src/main/java/de/adorsys/ledgers/deposit/api/domain/sca/SCAResponseTO.java
Outdated
Show resolved
Hide resolved
Koufan-De-King
previously approved these changes
Oct 4, 2024
nancymuyeh
reviewed
Oct 7, 2024
...st-api/src/main/java/de/adorsys/ledgers/deposit/api/exception/DepositHttpStatusResolver.java
Show resolved
Hide resolved
...st-api/src/main/java/de/adorsys/ledgers/deposit/api/exception/DepositHttpStatusResolver.java
Outdated
Show resolved
Hide resolved
...st-api/src/main/java/de/adorsys/ledgers/deposit/api/exception/DepositHttpStatusResolver.java
Outdated
Show resolved
Hide resolved
...st-api/src/main/java/de/adorsys/ledgers/deposit/api/exception/DepositHttpStatusResolver.java
Outdated
Show resolved
Hide resolved
...st-api/src/main/java/de/adorsys/ledgers/deposit/api/exception/DepositHttpStatusResolver.java
Outdated
Show resolved
Hide resolved
...st-api/src/main/java/de/adorsys/ledgers/deposit/api/exception/DepositHttpStatusResolver.java
Outdated
Show resolved
Hide resolved
...ccount-rest-api/src/main/java/de/adorsys/ledgers/deposit/api/exception/ExceptionAdvisor.java
Show resolved
Hide resolved
...ccount-rest-api/src/main/java/de/adorsys/ledgers/deposit/api/exception/ExceptionAdvisor.java
Show resolved
Hide resolved
Elwizzy12
dismissed stale reviews from Arielpetit and Koufan-De-King
via
69b54f8
Elwizzy12
requested review from
Arielpetit,
Koufan-De-King,
nancymuyeh and
NkwaTambe
NkwaTambe
previously approved these changes
Oct 8, 2024
Koufan-De-King
approved these changes
Oct 8, 2024
Arielpetit
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the ledgers-deposit-account-rest-api module and have added REST API endpoints for:
Creating a bank account.
Adding money to the account.
Querying account balances.
Transferring money between accounts.
Ensure no access control is implemented for now.