Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.0 #26

Merged
merged 30 commits into from
Aug 7, 2024
Merged

Release v1.0.0 #26

merged 30 commits into from
Aug 7, 2024

Conversation

AElfBourneShi
Copy link
Collaborator

@AElfBourneShi AElfBourneShi commented Aug 7, 2024

close #24
close #16
close #17
close #20

AElfBourneShi and others added 30 commits April 16, 2024 14:37
Feature: Supports sub object order by query
Feature: Support custom create index settings
Feature: Supports Elasticsearch search after query
* feat: delete index

* fix: sub object query of Multiple levels

* feat: optimize index delete method

* fix: recover unit test

* feat: add GitHub Action for NuGet publish

* feat: add GitHub Action for unit test and code coverage

---------

Co-authored-by: jason-aelf <[email protected]>
Copy link

vizipi bot commented Aug 7, 2024

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
80.56% ZhangXin 20 29
66.67% fengyan2023 6 24
38.89% Stephen02Zhang 2 14
22.22% louis.li 7 8
8.33% jason-hoopox 3 3

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
...src/AElf.EntityMapping.Elasticsearch/Repositories/Elastic66.67%2 out of 3 times
...test/AElf.EntityMapping.Elasticsearch.Tests/Sharding/Shar66.67%2 out of 3 times
src/AElf.EntityMapping/Sharding/IShardingKeyProvider.cs66.67%2 out of 3 times
...src/AElf.EntityMapping.Elasticsearch/Sharding/ShardingCol66.67%2 out of 3 times
src/AElf.EntityMapping/CollectionNameProviderBase.cs66.67%2 out of 3 times
src/AElf.EntityMapping/AElfEntityMappingModule.cs66.67%2 out of 3 times
...src/AElf.EntityMapping/Sharding/ICollectionRouteKeyProvid66.67%2 out of 3 times
...src/AElf.EntityMapping.Elasticsearch/AElfEntityMappingEla66.67%2 out of 3 times
src/AElf.EntityMapping.Elasticsearch/IndexNameHelper.cs66.67%2 out of 3 times
...test/AElf.EntityMapping.Elasticsearch.Tests/Sharding/Coll66.67%2 out of 3 times

Committed file ranks

(click to expand)
  • 69.72%[...test/AElf.EntityMapping.Tests/AElf.EntityMapping.Tests.cs]
  • 32.39%[...src/AElf.EntityMapping.Elasticsearch/Linq/QueryAggregator]
  • 79.58%[...src/AElf.EntityMapping.Elasticsearch/IElasticsearchClient]
  • 0.00%[...src/AElf.EntityMapping/Linq/EntityMappingNodeTypeProvider]
  • 32.39%[...test/AElf.EntityMapping.Elasticsearch.Tests/Entities/AeFi]
  • 86.62%[...src/AElf.EntityMapping.Elasticsearch/Services/IElasticInd]
  • 90.14%[...test/AElf.EntityMapping.Tests/AElfEntityMappingTestModule]
  • 83.80%[...test/AElf.EntityMapping.Elasticsearch.Tests/AElfElasticse]
  • 0.00%[...src/AElf.EntityMapping/Linq/EntityMappingEvaluatableExpre]
  • 73.94%[...test/AElf.EntityMapping.Elasticsearch.Tests/Elasticsearch]
  • Copy link

    codecov bot commented Aug 7, 2024

    Codecov Report

    Attention: Patch coverage is 57.26141% with 103 lines in your changes missing coverage. Please review.

    Project coverage is 77.08%. Comparing base (80f7347) to head (e8a631b).
    Report is 31 commits behind head on master.

    Files Patch % Lines
    ...ntityMapping/Linq/EntityMappingNodeTypeProvider.cs 62.74% 32 Missing and 6 partials ⚠️
    ...ping.Elasticsearch/Services/ElasticIndexService.cs 38.88% 18 Missing and 4 partials ⚠️
    ...asticsearch/Sharding/CollectionRouteKeyProvider.cs 16.00% 15 Missing and 6 partials ⚠️
    src/AElf.EntityMapping/Linq/AfterResultOperator.cs 40.74% 15 Missing and 1 partial ⚠️
    ...asticsearch/ElasticsearchCollectionNameProvider.cs 40.00% 1 Missing and 2 partials ⚠️
    src/AElf.EntityMapping/Linq/AfterExpressionNode.cs 80.00% 3 Missing ⚠️
    Additional details and impacted files

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##           master      #26      +/-   ##
    ==========================================
    - Coverage   79.98%   77.08%   -2.91%     
    ==========================================
      Files          27       33       +6     
      Lines        1564     1789     +225     
      Branches      195      219      +24     
    ==========================================
    + Hits         1251     1379     +128     
    - Misses        225      293      +68     
    - Partials       88      117      +29     
    Files Coverage Δ
    ...ping.Elasticsearch/IElasticsearchClientProvider.cs 100.00% <ø> (ø)
    ....Elasticsearch/Services/EnsureIndexBuildService.cs 96.55% <100.00%> (ø)
    ...ping.Elasticsearch/Sharding/ShardingKeyProvider.cs 86.45% <100.00%> (ø)
    ...yMapping/Linq/EntityMappingCachedReflectionInfo.cs 100.00% <100.00%> (ø)
    src/AElf.EntityMapping/Linq/QueryParserFactory.cs 100.00% <100.00%> (ø)
    src/AElf.EntityMapping/Linq/QueryableExtensions.cs 100.00% <100.00%> (ø)
    ...asticsearch/ElasticsearchCollectionNameProvider.cs 78.72% <40.00%> (+9.33%) ⬆️
    src/AElf.EntityMapping/Linq/AfterExpressionNode.cs 80.00% <80.00%> (ø)
    src/AElf.EntityMapping/Linq/AfterResultOperator.cs 40.74% <40.74%> (ø)
    ...asticsearch/Sharding/CollectionRouteKeyProvider.cs 70.56% <16.00%> (-6.95%) ⬇️
    ... and 2 more

    ... and 2 files with indirect coverage changes

    @jason-aelf jason-aelf merged commit 034e667 into master Aug 7, 2024
    8 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    4 participants