[Fix] 드래그앤드롭 원활하게 수정 #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Deploy Previewhttps://lettering-7ytfg8lnk-yyypearls-projects.vercel.app |
|
아하 그렇군요! 모바일에서 저도 테스트해봤는데 잘 되네요ㅎㅎ |
yyypearl
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
연관 이슈
close #93
✅ 작업 내용
초기에 startPosition을 인식하지 못하는 문제 때문에 드래그앤드롭이 잘 안되었던 거 였습니다!! (비동기 문제로 판단)
두번째에는 잘되었던 이유가 startPosition이 null이 아니게 되면서...? 인식할 수 있기 때문에 원활했던 것 같기도 합니다
그래서 따로 비동기 시에도 불러올 수 있게 startPositionRef를 따로 만들어 startPosition이 항상 값이 있는 상태를 유지하게 했습니다.
리뷰 요구사항
📝 기타 사항
그밖에 planet과 mypage의 로딩처리를 살짝 수정했어요!