Add fractal2d node
#2183
Open
Add fractal2d node
#2183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… MDL, along with simple unit tests for coverage - largely just cloning the work done for fractal3d
| return float4(c.x, c.y, c.z, a); | ||
| } | ||
|
|
||
| // TODO - do we want to rename these to mx_fractal3D_noise_float - if so where else might things need to be updated |
There was a problem hiding this comment.
That rename sounds logical to me, and I'm CC'ing @krohmerNV for his thoughts from the MDL side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring the existing behavior for
<fractal3d>, we add the corresponding<fractal2d> node that uses thetexcoord` input as its manifold.Add support for OSL, MSL, GLSL, MDL (note : MDL not tested).
Updated specification documents to add
<fractal2d>to the specification and remove it from the proposals document.Also remove
periodinputs for the noises that don't have those inputs in the specification. This is already documented in the proposals document.Note : in the GLSL noise library code I renamed the existing
mx_fractal_noise_xxx()functions tomx_fractal3d_noise_xxx()to make the differentiation cleaner with the newmx_fractal2d_noise_xxx(). But I retained wrapper functions with the old name that just call through to the new name for backwards compatibility. I was unsure how much custom customer code might be referencing those functions. We can remove the shim functions when we have another breaking API release.