Make closure addition a data-driven node #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstone-lucasfilm
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
This looks like a great improvement, thanks @ld-kerley, and let's plan to merge this after the upcoming v1.39.2 release.
jstone-lucasfilm
changed the title
jstone-lucasfilm
merged commit e0bced9
into
AcademySoftwareFoundation:main
34 checks passed
ld-kerley
added a commit
that referenced
this pull request
Jan 23, 2025
Following on from #2185. Moving closure layering, mixing and multiplication data-driven nodes. --------- Signed-off-by: Jonathan Stone <[email protected]> Co-authored-by: Jonathan Stone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by recent TSC conversations I decided to try and move one of the current C++ backed nodes to be data driven.
I believe this PR is mergable - but I encourage discussion around the direction taken. If the community is in alignment with this approach I believe there are a number of other nodes that could be given a similar treatment - bringing us closer to being a data driven format.