Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scikit-build-core #2189

Conversation

JeanChristopheMorinPerso
Copy link
Member

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Jan 21, 2025

We received an automated from PyPI:

This email is notifying you of an upcoming deprecation that we have determined may affect you as a result of your recent upload to 'MaterialX'.

In the future, PyPI will require all newly uploaded source distribution filenames to comply with PEP 625. Any source distributions already uploaded will remain in place as-is and do not need to be updated.

Specifically, your recent upload of 'MaterialX-1.39.2.tar.gz' is incompatible with PEP 625 because it does not contain the normalized project name 'materialx'.

In most cases, this can be resolved by upgrading the version of your build tooling to a later version that supports PEP 625 and produces compliant filenames.

If you have questions, you can email [email protected] to communicate with the PyPI [email protected] to communicate with the PyPI administrators.

So this PR does exactly what this email is asking about.

While updating, I took the decision to drop the custom plugin and instead rely on a built-in regex plugin to extract the version from cmake. This is much faster and won't tie the project to a specific scikit-build-core version.

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @JeanChristopheMorinPerso!

@jstone-lucasfilm jstone-lucasfilm merged commit 8e92b9e into AcademySoftwareFoundation:main Jan 22, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants