[rqd] Redirect transaction #1628
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting was previously being handled by code_style–ij.xml which is not really compatible with many new IDEs. This PR changes formating to GoogleStyle enforced by the spotless gradle plugin in conjunction with jdtls, which is compatible with vscode and eclipse.
The redirect logic is needs to happen on a single transaction to avoid a race condition where the redirect logic would unbook procs to dispatch the reserved job but the procs would be picked up by another thread booking general jobs. Besides adding a transation, this change ensures both unbookProc and dispatchHost calls run at the same thread to avoid escaping the transaction scope.
|
This commit is stacked on top of #1627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The redirect logic is needs to happen on a single transaction to avoid a race condition
where the redirect logic would unbook procs to dispatch the reserved job but the procs
would be picked up by another thread booking general jobs.
Besides adding a transaction, this change ensures both unbookProc and dispatchHost calls
run at the same thread to avoid escaping the transaction scope.