Start building on and for ARM. #3632
Draft
+43
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mitchell-as
commented
Jan 22, 2025
•
mitchell-as
commented
 DX-3211 [Vectra] We produce and automate ARM64 Linux builds for State Tool
|
mitchell-as
force-pushed
the
mitchell/dx-3211
branch
5 times, most recently
from
09d98a8 to
6f7a7a4
Compare
The github action uses an install.sh that doesn't have the necessary "arch" param from the previous commit.
mitchell-as
force-pushed
the
mitchell/dx-3211
branch
from
6f7a7a4 to
f11eb2e
Compare
Avoid arm64 runtime sourcing issues.
mitchell-as
force-pushed
the
mitchell/dx-3211
branch
from
f11eb2e to
81f6a2d
Compare
It downloads hardcoded amd64 binaries, which fails on arm64. Using `go install` should do the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.