[Don't merge] debug CI #1843
Closed
[Don't merge] debug CI #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cjao
commented
Nov 3, 2023
cjao
commented
- I have added the tests to cover my changes.
- I have updated the documentation and CHANGELOG accordingly.
- I have read the CONTRIBUTING document.
Introduce temporary implementations of `update._node` and `update.lattice_data`. These will be removed once core covalent is transitioned to the new DAL.
Change abs imports to rel imports. Needed to please pip-missing-reqs.
- Improve type hints
This reverts commit a3ab70b.
This reverts commit 388df38236ebec7555ec7e83ffc1834427b46650.
Make API endpoints restful Cancel all dispatches upon shutdown
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1843 +/- ##
===========================================
+ Coverage 80.17% 83.71% +3.53%
===========================================
Files 232 290 +58
Lines 10239 14127 +3888
Branches 193 193
===========================================
+ Hits 8209 11826 +3617
- Misses 1897 2168 +271
Partials 133 133
|
cjao
force-pushed
the
os-enhancements-preview-testmerge-debug
branch
2 times, most recently
from
2664212 to
a6adbd9
Compare
Previously, running `covalent start` would cause the config file to be updated from two processes: * the CLI runner, after confirming that the dispatcher server is up, * the DaskCluster process, which writes the state (such as scheduler_address). Unfortunately these updates were not synchronized with each other. If the Dask cluster finishes starting up and writes out its state before the CLI runner returns from `_graceful_start()`, the latter's config file update would obliterate the Dask cluster info. This patch ensures that the Dask cluster info is written to disk before the FastAPI server starts.
cjao
force-pushed
the
os-enhancements-preview-testmerge-debug
branch
from
575aed3 to
14f7258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.