Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix propagation of lattice-default attributes to electrons #1849

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

cjao
Copy link
Contributor

@cjao cjao commented Nov 14, 2023

Also use workflow_executor to build sublattice graphs

Closes #1781 .

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

Also use `workflow_executor` to build sublattice graphs
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #1849 (31c0aa5) into develop (e9559b5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 31c0aa5 differs from pull request most recent head da1f0d5. Consider uploading reports for the commit da1f0d5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1849      +/-   ##
===========================================
- Coverage    84.01%   84.01%   -0.01%     
===========================================
  Files          290      290              
  Lines        14120    14125       +5     
  Branches       193      193              
===========================================
+ Hits         11863    11867       +4     
- Misses        2124     2125       +1     
  Partials       133      133              
Flag Coverage Δ
Dispatcher 92.22% <ø> (ø)
Functional_Tests 51.75% <100.00%> (+0.01%) ⬆️
SDK 78.38% <94.11%> (+<0.01%) ⬆️
UI_Backend 85.05% <ø> (ø)
UI_Frontend 73.43% <ø> (ø)

@Andrew-S-Rosen
Copy link
Contributor

Huge thank you for this!!

@kessler-frost kessler-frost enabled auto-merge (squash) November 14, 2023 05:19
@kessler-frost kessler-frost enabled auto-merge (squash) November 14, 2023 05:22
@kessler-frost kessler-frost merged commit f2ad0f6 into develop Nov 14, 2023
10 checks passed
@kessler-frost kessler-frost deleted the i-1781-default-electron-metadata-fix branch November 14, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when setting executor in @ct.lattice: DaskExecutor object has no attribute scheduler_address
3 participants