Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for editing of Qelectron on settings page #1858

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

Aravind-psiog
Copy link
Collaborator

@Aravind-psiog Aravind-psiog commented Nov 22, 2023

  • I have added the tests to cover my changes.
  • I have updated the documentation and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

@Prasy12 Prasy12 changed the title Fix for editability of Qelectron on settings page Fix for editing of Qelectron on settings page Nov 22, 2023
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #1858 (7c9a61f) into develop (f2ad0f6) will decrease coverage by 1.12%.
Report is 2 commits behind head on develop.
The diff coverage is 46.15%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1858      +/-   ##
===========================================
- Coverage    84.01%   82.89%   -1.12%     
===========================================
  Files          290      260      -30     
  Lines        14125    12762    -1363     
  Branches       193      195       +2     
===========================================
- Hits         11867    10579    -1288     
+ Misses        2125     2049      -76     
- Partials       133      134       +1     
Flag Coverage Δ *Carryforward flag
Dispatcher 92.42% <ø> (+0.19%) ⬆️ Carriedforward from a13ddbb
Functional_Tests ?
SDK 78.63% <ø> (+0.24%) ⬆️ Carriedforward from a13ddbb
UI_Backend ?
UI_Frontend 73.35% <46.15%> (-0.09%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

@Aravind-psiog
Copy link
Collaborator Author

Hi @kessler-frost. This will fix the issue 1829. Can you review this PR and help us merge? TIA

@AlejandroEsquivel AlejandroEsquivel merged commit 3bcebff into develop Nov 23, 2023
11 of 12 checks passed
@AlejandroEsquivel AlejandroEsquivel deleted the ui-config-setting-changes branch November 23, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants