Add Solidus Alchemy menu items in initializer #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the menu items for Alchemy in an `after_initialize` hook rather than modifying the `spree.rb` initializer. The advantage here is that we can support both the new MenuItem API from Solidus 4.2+ as well as the old one. For people who have either not wrapped their in-app initializer in a `config.after_initialize` hook, we will also add a nice deprecation warning if they already have the Alchemy menu item in the list of menu items. For people who have wrapped their backend configuration in `after_initialize`, there is no hook we can hook into after that. They will see a double menu entry, and figure out to delete their own.
In order to prevent ordering issues we simply do that in normal init flow.
tvdeyen
approved these changes
Oct 25, 2023
|
Thanks 🍰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the menu items for Alchemy in an
after_initializehook rather than modifying thespree.rbinitializer. The advantage here is that we can support both the new MenuItem API from Solidus 4.2+ as well as the old one. For people who have either not wrapped their in-app initializer in aconfig.after_initializehook, we will also add a nice deprecation warning if they already have the Alchemy menu item in the list of menu items. For people who have wrapped their backend configuration inafter_initialize, there is no hook we can hook into after that. They will see a double menu entry, and figure out to delete their own.