Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deluge-meta: re-enable deluge-gtk, with caveats #24

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions Formula/deluge-meta.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class DelugeMeta < Formula
url "https://files.pythonhosted.org/packages/00/d7/8673068046ded6eaa82caaa2afd6f0751faf591aab5ad150aeafe0d47cb3/deluge-2.1.1.tar.gz"
sha256 "d6ea7e1f5bdd75f40cbd1d56f0c97cd1b5b74bc9e03783858c7daa81063dd4b9"
license "GPL-3.0"
revision 3
revision 4

bottle do
root_url "https://github.com/Amar1729/homebrew-deluge-meta/releases/download/deluge-meta-2.1.1_3"
Expand Down Expand Up @@ -126,7 +126,7 @@ class DelugeMeta < Formula
def install
virtualenv_install_with_resources using: "[email protected]"

%w[deluge deluge-console deluge-web deluged].each do |cmd|
%w[deluge deluge-console deluge-gtk deluge-web deluged].each do |cmd|
(bin/cmd).write_env_script(libexec/"bin/#{cmd}", PYTHONPATH: ENV["PYTHONPATH"])
end

Expand All @@ -141,6 +141,16 @@ def install
keep_alive true
end

def caveats
<<~EOS
To successfully launch the GUI (deluge or deluge-gtk) you MUST follow the procedure
detailed in https://github.com/Amar1729/homebrew-deluge-meta/issues/23 due to an
issue with an underlying dependency.

If you do not need to GUI, no extra steps are required.
EOS
end

test do
# this is not a "functional" test, but its a little tough to do one for a torrent client
assert_match "deluged #{version}", shell_output("#{bin}/deluged --version")
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# deluge-meta

This initially started as a "meta-package" for Deluge 2.0 dependencies on MacOS, but turned into a full installation of the `deluge` pip module, including the GUI `deluge-gtk`.
This initially started as a "meta-package" for Deluge 2.0 dependencies on MacOS, but turned into a full installation of the `deluge` pip module, including the GUI `deluge`/`deluge-gtk`.

Currently, Deluge 2.0 is in beta, but the newest release of the client available for MacOS is 1.x, which is incompatible with 2.0 servers. This tap provides a working (for now?) build for Deluge 2.0 to reduce the troubles with building and linking Deluge's pip module on Mac.

Expand Down
Loading