Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optional and hint stories #1669

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

dlnr
Copy link
Contributor

@dlnr dlnr commented Oct 17, 2024

Describe the pull request

It was unclear how to use the optional property for Label. When adding the story I noticed using the hintproperty is also not documented, and when you use hint optional is not required. So I've added another story for hint.

What

Just stories for Label

Checklist

Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:

  • Add or update unit tests
  • Add or update documentation
  • Add or update stories
  • Add or update exports in index.* files
  • Start the PR title with a Conventional Commit prefix, as explained here.

Additional notes

  • Provide links to any related issues or discussions.
  • Add a link to the specific story in the feature branch deploy.
  • Mention any areas where additional review or feedback is needed.

@github-actions github-actions bot temporarily deployed to demo-DES-970-label-optional-story October 17, 2024 14:16 Destroyed
Copy link
Contributor

@RubenSibon RubenSibon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow there were docs for FieldSet, but not for Label. Weird. Good that they are now added. LGTM!

@VincentSmedinga VincentSmedinga merged commit 2ba2332 into develop Oct 18, 2024
6 checks passed
@VincentSmedinga VincentSmedinga deleted the feature/DES-970-label-optional-story branch October 18, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants