Fix storing the display_field on the datasettable (#540)

A stringified tuple was saved to the database. Seems to be some kind of copy/paste error.
Amsterdam · Jan 23, 2024 · 613c6bf · 613c6bf
1 parent 4cf51d9
commit 613c6bf
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -1,3 +1,8 @@
+# 2024-01-22 (5.23.1)
+
+* Fix the storage of datasettables.display_field
+  (an old copy/paste error in the codebase)
+
 # 2024-01-12 (5.23.0)
 
 * Modified create_views functions to support materialized views

diff --git a/setup.cfg b/setup.cfg
@@ -1,6 +1,6 @@
 [metadata]
 name = amsterdam-schema-tools
-version = 5.23.0
+version = 5.23.1
 url = https://github.com/amsterdam/schema-tools
 license = Mozilla Public 2.0
 author = Team Data Diensten, van het Dataplatform onder de Directie Digitale Voorzieningen (Gemeente Amsterdam)

diff --git a/src/schematools/contrib/django/models.py b/src/schematools/contrib/django/models.py
@@ -406,7 +406,6 @@ def save_for_schema(self, table_schema: DatasetTableSchema):
         self.db_table = table_schema.db_name
         self.auth = " ".join(table_schema.auth)
         self.display_field = display_field.db_name if display_field is not None else None
-        self.display_field = ((display_field.db_name if display_field is not None else None),)
         self.geometry_field, self.geometry_field_type = self._get_geometry_field(table_schema)
         self.is_temporal = table_schema.is_temporal
         self.enable_geosearch = (