Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB#101824 Fix auth property for subfields. #535

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

jjmurre
Copy link
Contributor

@jjmurre jjmurre commented Dec 28, 2023

Field with subfields were not protected by the scope of the main field.

E.g.

  "soortCultuurOnbebouwd": {
    "auth": ["BRK/RO"],
    "type": "object",
    "properties": {
      "code": {
        "type": "string"
      },
      "omschrijving": {
        "type": "string"
      }
    }

Whe accessing the subfield soortCultuurOnbebouwdCode, the scope
"BRK/RO" should be applied, however, it was not.

This PR fixes that bug.

Field with subfields were not protected by the scope of the main field.

E.g. ```

  "soortCultuurOnbebouwd": {
    "auth": ["BRK/RO"],
    "type": "object",
    "properties": {
      "code": {
        "type": "string"
      },
      "omschrijving": {
        "type": "string"
      }
    }
```

Whe accessing the subfield `soortCultuurOnbebouwdCode`, the scope
"BRK/RO" should be applied, however, it was not.

This PR fixes that bug.
Copy link
Contributor

@gurustacks gurustacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Copy link
Contributor

@barrydaniels-nl barrydaniels-nl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@jjmurre jjmurre merged commit e334c9c into master Jan 8, 2024
4 checks passed
@jjmurre jjmurre deleted the jan/ab-101824-fix-auth-for-subfields branch January 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants