Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix storing the display_field on the datasettable #540

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix storing the display_field on the datasettable #540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 2024-01-22 (5.23.1)

* Fix the storage of datasettables.display_field
(an old copy/paste error in the codebase)

# 2024-01-12 (5.23.0)

* Modified create_views functions to support materialized views
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = amsterdam-schema-tools
version = 5.23.0
version = 5.23.1
url = https://github.com/amsterdam/schema-tools
license = Mozilla Public 2.0
author = Team Data Diensten, van het Dataplatform onder de Directie Digitale Voorzieningen (Gemeente Amsterdam)
Expand Down
1 change: 0 additions & 1 deletion src/schematools/contrib/django/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,6 @@ def save_for_schema(self, table_schema: DatasetTableSchema):
self.db_table = table_schema.db_name
self.auth = " ".join(table_schema.auth)
self.display_field = display_field.db_name if display_field is not None else None
self.display_field = ((display_field.db_name if display_field is not None else None),)
self.geometry_field, self.geometry_field_type = self._get_geometry_field(table_schema)
self.is_temporal = table_schema.is_temporal
self.enable_geosearch = (
Expand Down
Loading