fixed _clean_sql

CHANGES.md

@@ -1,3 +1,7 @@
+# 2024-01-31 (5.23.4)
+
+* Bugfix in _is_valid_sql
+
 # 2024-01-25 (5.23.3)
 
 * Fix in _is_valid_sql to fix materialized view problem.

setup.cfg

@@ -1,6 +1,6 @@
 [metadata]
 name = amsterdam-schema-tools
-version = 5.23.3
+version = 5.23.4
 url = https://github.com/amsterdam/schema-tools
 license = Mozilla Public 2.0
 author = Team Data Diensten, van het Dataplatform onder de Directie Digitale Voorzieningen (Gemeente Amsterdam)

src/schematools/contrib/django/management/commands/create_views.py

@@ -25,7 +25,7 @@ def _is_valid_sql(view_sql: str, view_name: str, write_role_name: str) -> bool:
             sid = transaction.savepoint()
             with connection.cursor() as cursor:
                 cursor.execute('SET statement_timeout = 5000;')
-                cursor.execute(view_sql)
+                cursor.execute(sql.SQL(view_sql))
             transaction.savepoint_rollback(sid)
     except Exception as e:  # noqa: F841
         return False
@@ -75,11 +75,7 @@ def _check_required_permissions_exist(
 def _clean_sql(sql) -> str:
     """Clean the SQL to make it easier to parse."""
 
-    sql = sql.replace("\n", " ").lower().strip()
-
-    if sql[-1] != ";":
-        sql += ";"
-
+    sql = sql.replace("\n", " ").strip()
     return sql
 
 
@@ -203,7 +199,7 @@ def create_views(
                                 )
 
                             # Create the view
-                            cursor.execute(view_sql)
+                            cursor.execute(sql.SQL(view_sql))
 
                             # Reset the role to the default role
                             cursor.execute("RESET ROLE")