Convert some core classes to C++ #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pybind11 generates a TypeError here
This header will contain common headers
C++ does not have virtual classmethods so the ABC was only useful for repr. A macro has been added to easily implement repr and state protocol.
This will analyse the C++ source code and generate a Visual Studio solution file and other needed file to allow compilation in Visual Studio. VS is much faster than pip install
Moved C++ source into the python package.
The version vector is now stored under vec
Some much has changed that the tests need re-doing. Moved them for now and will migrate them back slowly.
Added encode_long_array function. Refactored decode_long_array function. Added tests. Fixed a number of issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still heavily WIP but I am going to merge this as-is and continue developing with smaller pull requests.