Merge pull request #9 from jaumeMR/jaumeMR-try-catch

Try/catch for JSON.parse
Api2Pdf · Nov 15, 2020 · 0744a5b · 0744a5b
2 parents 407e25d + f1535de
commit 0744a5b
Showing 1 changed file with 23 additions and 13 deletions.
diff --git a/index.js b/index.js
@@ -75,31 +75,41 @@ module.exports = class Api2Pdf {
     return this._makeRequest(API2PDF_LIBREOFFICE_CONVERT, payload);
   }
 
-  delete(responseId) {
+    delete(responseId) {
     var endpoint = API2PDF_BASE_ENDPOINT + `/pdf/${responseId}`;
     return new Promise((resolve, reject) => {
       request.delete(endpoint, { headers: { Authorization: this.apiKey } }, function(e, r, body) {
-        var result = JSON.parse(body);
-        if (r.statusCode == 200 && result.success == true) {
-          return resolve(result);
-        }
-        else {
-          return reject(result);
+        try {
+            var result = JSON.parse(body);
+            if (r.statusCode == 200 && result.success == true) {
+            return resolve(result);
+            }
+            else {
+            return reject(result);
+            }
         }
+        catch (e) {
+            return reject(result)
+        };
       });
     });
   }
 
   _makeRequest(endpoint, payload) {
     return new Promise((resolve, reject) => {
       request.post({ url: endpoint, body: JSON.stringify(payload), headers: { Authorization: this.apiKey } }, function(e, r, body) {
-        var result = JSON.parse(body);
-        if (r.statusCode == 200 && result.success == true) {
-          return resolve(result);
-        }
-        else {
-          return reject(result);
+        try {
+            var result = JSON.parse(body);
+            if (r.statusCode == 200 && result.success == true) {
+            return resolve(result);
+            }
+            else {
+            return reject(result);
+            }
         }
+        catch (e) {
+            return reject(result)
+        };
       });
     });
   }