zsync files are not being generated

[Samueru-sama]

Looks like the static zsync has a problem because now everything that uses this appimagetool has missing zsync files.

Examples:

https://github.com/ivan-hc/Steam-appimage/releases/tag/continuous
https://github.com/pkgforge-dev/rofi-AppImage/releases/tag/405f523

Back in here I commented that the static zsync that probono has wasn't working, appimagetool would just say that everything went right without the zsync file being made.

[brunvonlope]

Can confirm: https://gitlab.gnome.org/GNOME/gimp/-/jobs/4553101

[Samueru-sama]

Looking at the build script, I don't see anything weird besides this patch?

[TheAssassin]

@brunvonlope it looks like you're using some other appimagetool. I can't see an appimagetool log.

[brunvonlope]

@TheAssassin The appimagetool log is omitted and saved as a file: https://gitlab.gnome.org/GNOME/gimp/-/jobs/4553101/artifacts/external_file/appimagetool.log

[Samueru-sama]

Another case

Brave AppImage Nightly v1.75.84 has the zsync file but the following releases do not.

I don't think you will get much from the build logs because appimagetool says that everything went right.

[TheAssassin]

Investigating already.

[TheAssassin]

The contained zsyncmake works just fine. Must be the way we call it.

[Samueru-sama]

The contained zsyncmake works just fine. Must be the way we call it.

That's odd because it used to work when the zsync from the runner was used instead, and back in the PR I tried to use the static zsyncmake binary on alpine by dropping it in PATH since the alpine repos don't have zsync and it didn't work, I had the same issue.

[TheAssassin]

I agree it is very odd. I cannot reproduce the issue when running a local build either. Could you please run a job with export VERBOSE=1 to get more output from appimagetool?

[Samueru-sama]

I agree it is very odd. I cannot reproduce the issue when running a local build either. Could you please run a job with export VERBOSE=1 to get more output from appimagetool?

https://github.com/Samueru-sama/rofi-AppImage-test/actions/runs/12247065805/job/34164200494

I don't see anything out of the ordinary, other than the .zsync file is missing.

Zen-browser will run into this issue when they make their next release as well, so I think right now what is best is to remove the bundled zsyncmake since this breaks all current workflows that use this appimagetool.

EDIT: It is too late about Zen, just checked the recent actions and the next release is being right now lol

[TheAssassin]

Sorry, my bad, you need to run with --verbose. We need to introduce an environment variable for it, I suppose.

[Samueru-sama]

Sorry, my bad, you need to run with --verbose. We need to introduce an environment variable for it, I suppose.

https://github.com/Samueru-sama/rofi-AppImage-test/actions/runs/12247228454/job/34164668295

[TheAssassin]

It looks like zsyncmake definitely was run. Could be a cwd issue, but I cannot reproduce it in my local dev build at the moment.

[Samueru-sama]

It looks like zsyncmake definitely was run. Could be a cwd issue, but I cannot reproduce it in my local dev build at the moment.

I don't think it is a cwd issue since it didn't happen before with the runner zsync.

The Zen appimage workflow will explicitly try to upload the .zsync file instead of uploading the files together with globs like others, so this is going to fail

[TheAssassin]

Looking at your log, we see the following excerpt:

Running zsyncmake process: '/tmp/appimage_extracted_39b45ea7ed6dff1a6cccf3ea17fbd40d/usr/bin/zsyncmake' '/__w/rofi-AppImage-test/rofi-AppImage-test/rofi/rofi-405f523-anylinux-x86_64.AppImage' '-u' 'rofi-405f523-anylinux-x86_64.AppImage' 
zsync: 0.6.2
Blocksize: 2048
Length: 0
Hash-Lengths: 1,2,3
SHA-1: da39a3ee5e6b4b0d3255bfef95601890afd80709

This is the zsync file's header. What is really odd is the Length: 0. Also, I wouldn't expect to see the zsync header at all, zsync doesn't usually print it. I'm a bit lost currently.

For the record, using the statically linked zsyncmake, it looks like that doesn't produce a .zsync file either...

[TheAssassin]

Workaround implemented in #85. Backed up old binaries in https://github.com/AppImage/appimagetool/releases/tag/broken-zsyncmake.

[Samueru-sama]

Omg the timing:

Turns out Zen was running two jobs, one downloaded the appimagetool before #85 and another after and it resulted in that! Now the guy is going to be left wondering why one job randomly failed lol.