Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output version to stdout #89

Merged
merged 2 commits into from
Dec 29, 2024
Merged

output version to stdout #89

merged 2 commits into from
Dec 29, 2024

Conversation

Samueru-sama
Copy link
Contributor

@Samueru-sama Samueru-sama commented Dec 28, 2024

Fixes #88

Had to disable the building of zsync make because that was failing for some reason, that isn't being bundled anyway due to #84

EDIT: Test:

image

@TheAssassin
Copy link
Member

Given that the file wasn't checksummed anyway, it's probably a good idea to disable the build until further notice. The unnecessary -q flag prevents us from seeing what's going on there.

@TheAssassin
Copy link
Member

Looks like the really old zsync homepage has been deactivated:

The site moria.org.uk has been disabled. Please contact support.

We should use our own zsyncmake2 anyway, really...

@Samueru-sama
Copy link
Contributor Author

We should use our own zsyncmake2 anyway, really...

I did some tests a while back with zsync2 and it wasn't working due to this

src/appimagetool.c Outdated Show resolved Hide resolved
Copy link
Member

@TheAssassin TheAssassin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove your last commit.

@TheAssassin
Copy link
Member

That's the point, yes. Let me fix the branch manually because squashing it entirely is not an option.

Needs to be fixed separately. It's not shipped at the moment anyway due
to other issues.
@TheAssassin TheAssassin enabled auto-merge (rebase) December 29, 2024 15:45
@TheAssassin TheAssassin merged commit 8e5b4c0 into AppImage:main Dec 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appimagetool --version is not output to stdout
3 participants