MissionPlanner:add DO_SET_HOME to Copter and Rover #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this, I agree we should add support the DO_SET_HOME command to the list of available commands for all vehicles. I wonder if this is the correct file to modify though, perhaps its moved but the last time I did something similar I modified the mavcmd.xml file in the top level folder. |
rmackay9
reviewed
Dec 30, 2024
rmackay9
reviewed
Dec 30, 2024
| @@ -210,7 +210,16 @@ | |||
| <Y></Y> | |||
| <Z></Z> | |||
| </DO_SET_CAM_TRIGG_DIST> | |||
| <DO_SET_RELAY> | |||
| <DO_SET_HOME> | |||
| <P1>Current(1)/Spec(0)</P1> | |||
There was a problem hiding this comment.
this is fine of course but I might shorten it to just "Current(1)". just an idea though, I'm fine either way
There was a problem hiding this comment.
was just a copy and paste...not sure I know exactly how to change and if we do, shouldn't we change the other instances here?
|
Apparently, both this and the toplevel needs changing, from PeteHall's....will do
|
Hwurzburg
force-pushed
the
add_do_set_home
branch
from
1ef57a4 to
0aa00a4
Compare
rmackay9
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command/mission item implemented but not listed