-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grammar errors #827
base: main
Are you sure you want to change the base?
Fix grammar errors #827
Conversation
How to use the Graphite Merge QueueAdd the label graphite/merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThis pull request consists of minor typographical corrections across several files in the codebase. The changes primarily involve fixing spelling errors in comments, error messages, and linter directives. These modifications do not alter the functional behavior of the code but improve readability and accuracy of textual elements. The corrections span multiple files in the cardinal and relay packages, addressing typos in words like "sequencer", "occurred", "automatically", "essentially", "storage", and a linter directive. Changes
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
relay/nakama/testutils/testutils.go (1)
158-158
: Add explanation for the nolint directive.The grammar fix from
decorder
todecoder
looks good. However, as per the linter suggestion, please add an explanation for why we're disabling this check.-type FakeNakamaModule struct { //nolint:decoder +type FakeNakamaModule struct { //nolint:decoder // Allowing custom field ordering for test implementation🧰 Tools
🪛 golangci-lint (1.62.2)
158-158: directive
//nolint:decoder
should provide explanation such as//nolint:decoder // this is why
(nolintlint)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
cardinal/router/router.go
(1 hunks)cardinal/world.go
(1 hunks)cardinal/world_fixture.go
(1 hunks)relay/nakama/auth/custom.go
(1 hunks)relay/nakama/siwe/siwe.go
(1 hunks)relay/nakama/testutils/testutils.go
(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- cardinal/router/router.go
- relay/nakama/auth/custom.go
- cardinal/world.go
- cardinal/world_fixture.go
- relay/nakama/siwe/siwe.go
🧰 Additional context used
🪛 golangci-lint (1.62.2)
relay/nakama/testutils/testutils.go
158-158: directive //nolint:decoder
should provide explanation such as //nolint:decoder // this is why
(nolintlint)
This pull request improves the readability and professionalism of the code by fixing grammar errors in the comments and error handling messages across multiple files in the project.
Brief Changelog
Testing and Verifying
Summary by CodeRabbit
Documentation
Chores