metadata: add support for JPG thumbnails #679
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, why did they do this... 🤦♂️ |
|
sry... i don't know why... i also cannot find a solution/setting zu change the background color of image. so its just black. |
|
JPG doesn't have alpha channel, so no surprise the background is black, but I guess we are still missing the QOI image format? |
|
Yeah. I just search for a default background colour PS, but I don't found anything... |
pedrolamas
reviewed
Aug 11, 2023
Comment on lines
222
to
223
| r"; (thumbnail|thumbnail_JPG)? begin([;/\+=\w\s]+?)" | ||
| r"; (?:thumbnail|thumbnail_JPG)? end", data) |
There was a problem hiding this comment.
I think you want both in non-capture mode and not-optional:
Suggested change
| r"; (thumbnail|thumbnail_JPG)? begin([;/\+=\w\s]+?)" | |
| r"; (?:thumbnail|thumbnail_JPG)? end", data) | |
| r"; (?:thumbnail|thumbnail_JPG) begin([;/\+=\w\s]+?)" | |
| r"; (?:thumbnail|thumbnail_JPG) end", data) |
There was a problem hiding this comment.
Thx! I did a force push with the fix. I think arksine merged the commits directly.
Thx to pedrolamas for the regex fix Signed-off-by: Stefan Dej <[email protected]>
meteyou
force-pushed
the
feat/add-jpg-thumbnail-support
branch
from
6979abb to
f354f42
Compare
|
FWIW, my PR to add QOI and JPG thumbnails support to Windows PowerToys has been merged and will be available on the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for JPG thumbnails. I tested it with PrusaSlicer 2.6.0: