Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata: support multiple filaments length for prusaslicer #756

Conversation

bakatrouble
Copy link
Contributor

@bakatrouble bakatrouble commented Nov 26, 2023

The metadata parser was unable to parse used filament length when the slicer is set up for MMU, resulting in line
; filament used [mm] = 0, 0, 0, 0, 31653.68

Signed-off-by: Aleksey Frolov <[email protected]>

@Arksine
Copy link
Owner

Arksine commented Nov 28, 2023

Thanks. The changes look ok, however the commits need to be signed off before they can be merged. It is sufficient to add the Signed-off-by line to the PR if you don't want to amend the commits themselves.

@bakatrouble
Copy link
Contributor Author

Thanks. The changes look ok, however the commits need to be signed off before they can be merged. It is sufficient to add the Signed-off-by line to the PR if you don't want to amend the commits themselves.

Added to the pr message

@Arksine
Copy link
Owner

Arksine commented Dec 18, 2023

Thanks, however the signature requires your real name, not an alias.

@bakatrouble
Copy link
Contributor Author

Changed

@Arksine Arksine merged commit 6b1b8c5 into Arksine:master Mar 6, 2024
1 check passed
@Arksine
Copy link
Owner

Arksine commented Mar 6, 2024

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants