Update smbsettings.md

[pheltzel]

Updates to clarify SMB settings.

See https://docs.google.com/document/d/194VKaSP5qfFrsvQXlEnxnDcru5hwIjQJwOQ9-bMZb0I/edit

for full edit.

[sethgagnon]

Looks like there are some conflicts here that need to be resolved first. I did have to switch all your PRs to merge to dev branch. We always push PRs to dev branch first so you can test the site and your changes there first.

[pheltzel]

Looks like there are some conflicts here that need to be resolved first. I did have to switch all your PRs to merge to dev branch. We always push PRs to dev branch first so you can test the site and your changes there first.

Thanks, Seth. What is the correct process to start editing to they're pushed to dev instead? I typically start at this site:

https://iaps.readthedocs.io/en/main/

is there a dev version of that site for preview?

....then click Edit on Github, make the edits, and click Commit. Should I start some place else -- or otherwise set the PR to go to dev vs. main? I wasn't even aware there was a dev site for documents vs. code changes.

This was the first time I submitted the PRs vs just clicking Commit. Can you just point me to the right process? No need to answer the questions above if you can just point me to the right way to do it.

Best--Paul

[sethgagnon]

Yeah no worries at all. Yes, there is a dev version of that read the docs site. You can change to dev in the bottom lower left of the screen. If you change to dev first there, then make your edits it will submit to dev branch. After we merge your PR, you can go back to the dev version of the site to see your changes. If all looks good there, we can then merge to main (official version). Seth Gagnon

…

________________________________ From: Paul Heltzel ***@***.***> Sent: Monday, January 29, 2024 1:06:45 PM To: Artificial-Pancreas/iAPSdocs ***@***.***> Cc: sethgagnon ***@***.***>; Comment ***@***.***> Subject: Re: [Artificial-Pancreas/iAPSdocs] Update smbsettings.md (PR #151) Looks like there are some conflicts here that need to be resolved first. I did have to switch all your PRs to merge to dev branch. We always push PRs to dev branch first so you can test the site and your changes there first. Thanks, Seth. What is the correct process to start editing to they're pushed to dev instead? I typically start at this site: https://iaps.readthedocs.io/en/main/ is there a dev version of that site for preview? ....then click Edit on Github, make the edits, and click Commit. Should I start some place else -- or otherwise set the PR to go to dev vs. main? I wasn't even aware there was a dev site for documents vs. code changes. This was the first time I submitted the PRs vs just clicking Commit. Can you just point me to the right process? No need to answer the questions above if you can just point me to the right way to do it. Best--Paul — Reply to this email directly, view it on GitHub<#151 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAER7RUWI7JQ3DKNZZBHGHLYQ7QLLAVCNFSM6AAAAABCOMBN42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVGI4DQMJTGU>. You are receiving this because you commented.Message ID: ***@***.***>

[pheltzel]

To: Artificial-Pancreas/iAPSdocs @.***>

Cc: sethgagnon @.>; Comment @.>

Subject: Re: [Artificial-Pancreas/iAPSdocs] Update smbsettings.md (PR #151)

Looks like there are some conflicts here that need to be resolved first. I did have to switch all your PRs to merge to dev branch. We always push PRs to dev branch first so you can test the site and your changes there first.

Thanks, Seth. What is the correct process to start editing to they're pushed to dev instead? I typically start at this site:

https://iaps.readthedocs.io/en/main/

is there a dev version of that site for preview?

....then click Edit on Github, make the edits, and click Commit. Should I start some place else -- or otherwise set the PR to go to dev vs. main? I wasn't even aware there was a dev site for documents vs. code changes.

This was the first time I submitted the PRs vs just clicking Commit. Can you just point me to the right process? No need to answer the questions above if you can just point me to the right way to do it.

Best--Paul

—

You are receiving this because you commented.Message ID: @.***>

[pheltzel]

Got it. One more question: After clicking "Commit changes..." is there another step to make it a PR that gets reviewed -- or does that get the job done? Thanks!