Add page recreating the two GHUV fields #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
AdamRJensen
reviewed
Feb 14, 2023
| @@ -0,0 +1,146 @@ | |||
| { | |||
There was a problem hiding this comment.
Can we call it VARIABLE_MAP to be consistent with pvlib? :D
Also, is there a reason that you are using hyphens and not underscores in the mapped variable names?
Reply via ReviewNB
There was a problem hiding this comment.
Also, is there a reason that you are using hyphens
Just matching the PSM3 API, which uses hyphens for the two ghuv fields: https://developer.nrel.gov/docs/solar/nsrdb/psm3-download/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took some detective work to track down how these two fields are calculated. The NSRDB team has a JPV paper from some years ago with a very similar model, but it lacks the necessary details to actually reproduce their calculations. Eventually the breadcrumbs led me to ASTM G222-21, which does contain the necessary detail.