generated from emilk/eframe_template
-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminal rewrite #116
Merged
Merged
Terminal rewrite #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
white-axe
requested changes
Mar 22, 2024
white-axe
reviewed
Mar 22, 2024
white-axe
requested changes
Mar 22, 2024
white-axe
requested changes
Mar 22, 2024
white-axe
reviewed
Mar 23, 2024
white-axe
approved these changes
Mar 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The terminal still causes the screen to render every frame when it's focused, but this seems to be an egui or eframe bug since egui's TextEdit also causes this to happen in Linux native builds when focused but not in web builds. Everything else is good, though!
white-axe
reviewed
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#89
Description
This PR replaces wezterm with alacritty_terminal, which is on crates.io. It means that we've had to implement more functionality of a terminal emulator but we are at least no longer depending on a crate not intended for public use.
This PR also adds terminal configuration and fixes the way that Luminol playtests games. The config is not currently editable through a UI though, that'll probably be added in a separate pull request.
Additionally, terminals now automatically size themselves based on the ui they're placed in! This means we don't have any dragvalues to resize terminals anymore.
Testing
I've been testing by running various things through the terminal, each trying to test a different feature of the terminal.
Checklist
cargo fmt
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown -Z build-std=std,panic_abort
cargo build --release
trunk build --release