Allow protocol sync to rewrite paratoo internal ids #823

AtlasOfLivingAustralia · Feb 6, 2024 · 0bfbcdb · 0bfbcdb
1 parent 7cfb777
commit 0bfbcdb
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/grails-app/services/au/org/ala/ecodata/ParatooService.groovy b/grails-app/services/au/org/ala/ecodata/ParatooService.groovy
@@ -288,11 +288,12 @@ class ParatooService {
                 log.info message
             }
             else {
-                String message = "Updating form with id: "+id+", guid: "+guid+", name: "+name+", new id: "+id
+                ExternalId paratooInternalId = form.externalIds.find{it.idType == ExternalId.IdType.MONITOR_PROTOCOL_INTERNAL_ID}
+
                 // Paratoo internal protocol ids are not stable so if we match the guid, we may need to update
                 // the id as that is used in other API methods.
-                ExternalId paratooInternalId = form.externalIds.find{it.idType == ExternalId.IdType.MONITOR_PROTOCOL_INTERNAL_ID}
                 if (paratooInternalId) {
+                    String message = "Updating form with id: "+paratooInternalId.externalId+", guid: "+guid+", name: "+name+", new id: "+id
                     paratooInternalId.externalId = id
                 }
                 else {