Add a launch site button to the admin bar. #41240

youknowriad · 2025-01-22T10:18:41Z

Proposed changes:

We recently removed the "launch bar" from the frontend of wp.com websites, that said, it's important for users to know that there's site is yet to be launched for users as raised by @scruffian

The current PR adds a "launch site" button to the admin bar of both simple and atomic sites.

Testing instructions:

apply the PR changes
Open the frontend of your unlaunched site
Notice the "launch site" button in the admin bar
Click the button and launch your site
The button is gone from the admin bar.

Does this pull request change what data or activity we track or use?

No

github-actions · 2025-01-22T10:19:33Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/launch-button branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/launch-button

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-22T10:19:43Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Mu Wpcom plugin:

Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

youknowriad · 2025-01-22T10:19:55Z

projects/packages/jetpack-mu-wpcom/src/features/launch-button/index.php

+	} else if ( function_exists( '\WPCOM\Lib\Launch_Site\is_launched' ) ) {
+		$is_launched = \WPCOM\Lib\Launch_Site\is_launched( $blog_id );
+		$blog_domain  = preg_replace( '!^https?://!', '', get_primary_redirect( $blog_id ) );
+	}


Finding the right APIs to use has been challenge. I'm not sure I'm covering all the subtle use-cases either.
I would love if we had a "codex" or "dev docs" to know which APIs are available to which sites, otherwise, it feels like we're just hacking things together.

I would love if we had a "codex" or "dev docs" to know which APIs are available to which sites

That would be great indeed. In practice, we currently need to do some digging or look at prior art to get familiar with newer things.

In this specific use-case, there is prior art with #36839, where as you can see, they sticked to the same option check in both environments.

Do you know if there's a consistent way to get the "domain name" as well (between atomic and simple) to avoid the condition.

youknowriad · 2025-01-22T10:21:10Z

projects/packages/jetpack-mu-wpcom/src/features/launch-button/style.css

@@ -0,0 +1,3 @@
+#wpadminbar .launch-site {
+	background: var(--wp-admin-theme-color);


I've used the admin color CSS variable to try to stay consistent with the admin bar but I noticed that these variables don't contain the right values. I think this is out of scope of the current PR. I know some folks are working on making sure the right colors are used everywhere.

jeherve · 2025-01-22T14:50:07Z

projects/packages/jetpack-mu-wpcom/src/features/launch-button/index.php

+	$is_launched = true;
+	$blog_id = get_current_blog_id();
+
+	if ( defined( 'IS_ATOMIC' ) && IS_ATOMIC ) {


Since you use the Status package in that file already, you could switch to using is_woa_site from Status\Host

jeherve · 2025-01-22T14:52:52Z

projects/packages/jetpack-mu-wpcom/src/features/launch-button/index.php

+		$is_launched = get_option( 'launch-status' ) === 'launched';
+		$blog_domain = ( new Status() )->get_site_suffix();
+	} else if ( function_exists( '\WPCOM\Lib\Launch_Site\is_launched' ) ) {
+		$is_launched = \WPCOM\Lib\Launch_Site\is_launched( $blog_id );


When you run into PhanUndeclaredFunction or other Phan errors, this can be a good help:
pdWQjU-Jb-p2

jeherve · 2025-01-22T14:54:02Z

projects/packages/jetpack-mu-wpcom/src/features/launch-button/index.php

+	} else if ( function_exists( '\WPCOM\Lib\Launch_Site\is_launched' ) ) {
+		$is_launched = \WPCOM\Lib\Launch_Site\is_launched( $blog_id );
+		$blog_domain  = preg_replace( '!^https?://!', '', get_primary_redirect( $blog_id ) );
+	}


I would love if we had a "codex" or "dev docs" to know which APIs are available to which sites

That would be great indeed. In practice, we currently need to do some digging or look at prior art to get familiar with newer things.

In this specific use-case, there is prior art with #36839, where as you can see, they sticked to the same option check in both environments.

projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php

fushar · 2025-01-23T14:39:25Z

projects/packages/jetpack-mu-wpcom/src/features/launch-button/index.php

+ *
+ * @param WP_Admin_Bar $admin_bar The WordPress admin bar.
+ */
+function wpcom_add_launch_button_to_admin_bar( WP_Admin_Bar $admin_bar ) {


We need to check whether the user is the admin of the site. Currently, the launch button shows up for everyone, even logged-out users, which is unexpected.

Isn't the admin bar only shown for logged-in users. Also if I'm not wrong, if your site is unlaunched, no one is going to see the site (it's going to show the coming soon message) no?

I guess in other words, how do I reproduce the issue?

This is how we can reproduce the issue:

Create a new unlaunched SIMPLE site.

Patch this PR to the sandbox.

Add a new user as Editor/Author.

Log in to WordPress.com as that user (e.g. in another browser window).

Open the site frontend as that user.

You will see the admin bar with the launch button, which shouldn't be there. (Clicking the button will not launch the site)

Isn't the admin bar only shown for logged-in users.

Yeah, sorry, it won't be shown logged-out users. (Except if you're seeing an ATOMIC site frontend while PROXIED, which is a weird case and can be ignored). But the above case still applies -- we need to check for the current user's permission.

So, I was actually unable to reproduce this issue. The Editor/Author can't see the frontend of the website and only see a "coming soon" page for me, so there's no admin bar.

That said, I pushed a code to add a check. Some small defensive coding is not that bad.

projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php

richtabor · 2025-01-23T20:53:18Z

Nice.

We should consider adding a confirmation dialog to clarify what launching entails. This will help users determine if they’re truly ready to proceed while providing a seamless and tasteful opportunity to upgrade their site.

If launching is intentional and meaningful, it can also serve as a well-timed upsell moment (that's persistent if left "unlaunched". I'll write up some thoughts on this front.

youknowriad · 2025-01-25T17:21:05Z

If launching is intentional and meaningful, it can also serve as a well-timed upsell moment (that's persistent if left "unlaunched". I'll write up some thoughts on this front.

I think this is already the case, launching send you to a wizard to pick a domain/plan if you didn't pick one yet.

For the confirmation, are you thinking about a regular browser confirm dialog? To be honest, I'm not entirely sure about this interaction. The launch wizard is already something you can abort at any time.

ellatrix · 2025-01-27T09:05:36Z

projects/packages/jetpack-mu-wpcom/src/features/launch-button/index.php

+		$blog_id     = get_current_blog_id();
+		$blog_domain = preg_replace( '!^https?://!', '', get_primary_redirect( $blog_id ) );
+	}
+	if ( $is_launched ) {


Nit: you could return earlier.

ellatrix · 2025-01-27T09:07:49Z

projects/packages/jetpack-mu-wpcom/src/features/launch-button/index.php

+		$blog_domain = ( new Status() )->get_site_suffix();
+	} else {
+		$blog_id     = get_current_blog_id();
+		$blog_domain = preg_replace( '!^https?://!', '', get_primary_redirect( $blog_id ) );


You can use wp_parse_url( home_url(), PHP_URL_HOST ) I think?
This is what the site management widget currently uses (untouched by me).
Also I think it's using that for both simple and atomic.

I copied this code from the previous launch bar we had in the frontend but I can try your suggestion. There's so many ways of doing the same things and no reference for these things. I think we need this reference at some point.

ellatrix

Tested and works for me. It's a bit weird that it sends you to the same flow as the one for creating a new site, but it has nothing to do with this PR.

ellatrix · 2025-01-27T13:41:11Z

I'm seeing a little bug with the colours. Strange because previously it was correct 🤔

A bit later I'm seeing that's it's only temporarily this colour upon refresh, then it becomes the right colour.

youknowriad added 2 commits January 22, 2025 11:06

Add Launch Button to the admin bar

f4ce75f

changelog

b4845da

youknowriad added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 22, 2025

youknowriad requested review from scruffian, oandregal, mmtr, fushar and jorgefilipecosta January 22, 2025 10:18

youknowriad self-assigned this Jan 22, 2025

github-actions bot added [Package] Jetpack mu wpcom WordPress.com Features [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh labels Jan 22, 2025

youknowriad commented Jan 22, 2025

View reviewed changes

youknowriad requested a review from richtabor January 22, 2025 10:21

Fix PHPCS

1a8b69a

jeherve added [Status] Needs Team Review and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jan 22, 2025

jeherve reviewed Jan 22, 2025

View reviewed changes

fushar reviewed Jan 23, 2025

View reviewed changes

projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php Outdated Show resolved Hide resolved

youknowriad added 3 commits January 23, 2025 11:32

simplify launched condition

f792b76

Alphabetic order

ed277bb

Fix phpcs

276927b

youknowriad force-pushed the add/launch-button branch from acd5992 to 276927b Compare January 23, 2025 14:21

fushar reviewed Jan 23, 2025

View reviewed changes

Check for manage options

e48c950

Load the styles in the admin as well

77eaa21

ellatrix reviewed Jan 27, 2025

View reviewed changes

ellatrix previously approved these changes Jan 27, 2025

View reviewed changes

youknowriad dismissed ellatrix’s stale review via 4d43e69 January 27, 2025 10:11

Simplification per review

fbf1307

youknowriad force-pushed the add/launch-button branch from 4d43e69 to fbf1307 Compare January 27, 2025 10:16

youknowriad merged commit c3f0796 into trunk Jan 27, 2025
60 checks passed

youknowriad deleted the add/launch-button branch January 27, 2025 11:39

github-actions bot removed the [Status] Needs Team Review label Jan 27, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a launch site button to the admin bar. #41240

Add a launch site button to the admin bar. #41240

youknowriad commented Jan 22, 2025 •

edited by richtabor

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

youknowriad Jan 22, 2025

jeherve Jan 22, 2025

youknowriad Jan 23, 2025

youknowriad Jan 22, 2025

jeherve Jan 22, 2025

jeherve Jan 22, 2025

jeherve Jan 22, 2025

fushar Jan 23, 2025

youknowriad Jan 23, 2025 •

edited

Loading

fushar Jan 23, 2025

youknowriad Jan 25, 2025

richtabor commented Jan 23, 2025

youknowriad commented Jan 25, 2025

ellatrix Jan 27, 2025

ellatrix Jan 27, 2025

youknowriad Jan 27, 2025

ellatrix left a comment

ellatrix commented Jan 27, 2025

		@@ -0,0 +1,3 @@
		#wpadminbar .launch-site {
		background: var(--wp-admin-theme-color);

Add a launch site button to the admin bar. #41240

Add a launch site button to the admin bar. #41240

Conversation

youknowriad commented Jan 22, 2025 • edited by richtabor Loading

Proposed changes:

Testing instructions:

Does this pull request change what data or activity we track or use?

github-actions bot commented Jan 22, 2025 • edited Loading

github-actions bot commented Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youknowriad Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richtabor commented Jan 23, 2025

youknowriad commented Jan 25, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ellatrix left a comment

Choose a reason for hiding this comment

ellatrix commented Jan 27, 2025

youknowriad commented Jan 22, 2025 •

edited by richtabor

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

github-actions bot commented Jan 22, 2025 •

edited

Loading

youknowriad Jan 23, 2025 •

edited

Loading