Port Respawn Button from Cosmatic Drift. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I expect the tests to fail here when you run them until #8 is merged. |
|
Going to talk with the team before merging this one. |
I opted to manually integrate the patch because this was before we started namespaceing things. Based on the following cosmatic drift commit by Lank cosmatic-drift-14/cosmatic-drift@1474f05
This fixes a bug with the respawn button where it did not show the cooldown properly. Taken from cosmatic-drift-14/cosmatic-drift#135
dffdff2423
force-pushed
the
axolotol-respawn
branch
from
2beedec to
cc45c12
Compare
|
That test failure is unrelated to my code. I thought it was just the loadout that was causing issues. I guess I was wrong. Not entirely sure what the issue is, but I did not touch any of the code relating to starting the round. |
|
I think its a heisentest thats happening upstream as well |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
bhenrich
previously requested changes
Jun 14, 2024
VasilisThePikachu
dismissed
bhenrich’s stale review
mrrrrp meow~ (review has been satisfied)
|
awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Ports the respawn button from Cosmatic Drift. Most of this code was originally made by Lank.
Why / Balance
I expect this would be reverted when the server is higher pop, but I think it would be nice to not have to stay as a ghost while the server is such low pop. I have seen it where most of the payers are ghosts that would join if they were able to.
Technical details
Cherry-Picks the following commits/PRs from CD:
I ended up manually integrating them because they were created before we started namspacing things on CD.
Media
Breaking changes
A public method on the ghost gui had it's prototype changed, but this is not really a big deal.
Changelog
🆑 Aquif, Whoever this was copy-pasted from.