Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work to have data automatically generated. To make this happ… #15

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

benrunchey
Copy link
Contributor

…en in "monolith" mode RentalApplication w/ the "simulator" profile active. If running microservices, add the "simulator" profile to the UserInterface microservice.

…n in "monolith" mode RentalApplication w/ the "simulator" profile active. If running microservices, add the "simulator" profile to the UserInterface microservice.
@benrunchey benrunchey requested a review from dgomezg April 12, 2024 02:52
Copy link
Contributor

@dgomezg dgomezg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me the simulation was not triggered until I changed the Flux<String>.subscribe() by .toStream().forEach(logger::info)... probably because the method in which subscribe() is called does not return anything, and it may be just that the JVM is optimizing that code away.

Ben Runchey and others added 4 commits April 22, 2024 14:27
Addressing code review comments
…n in "monolith" mode RentalApplication w/ the "simulator" profile active. If running microservices, add the "simulator" profile to the UserInterface microservice.
@dgomezg
Copy link
Contributor

dgomezg commented Apr 23, 2024

I've merged latest changes from the docs, and updated the tutorial to integrate some of the changes.

I've launched the application and connected it to AxonIQ Console, and now it looks really useful thanks to that constant activity provided by the simulator.

My main concern (the activity not being launched) has been addressed. The rest of the comments, we will improve and iterate over time. But I think it will be useful to show activity and the usefulness of AxonIQ Console as it is now.

Hence, I'm approving the PR to be merged.

image
image
image
image

@benrunchey benrunchey merged commit 29fe4f2 into main Apr 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants