-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCP support #144
Merged
Merged
Add GCP support #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tested
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
Makefile
, Go source files, and documentation, primarily focusing on adding new functionality, updating configurations, and improving documentation. The most important changes are grouped by theme below:Makefile Enhancements:
image-clean
target to remove Docker images.clean
target to remove additional binaries specified byCONTRIB_BINARIES
.Go Source File Updates:
ApplyPriorityLevelConfiguration
function incmd/kperf/commands/utils/helper.go
to apply Kubernetes PriorityLevelConfiguration usingkubectl
.cmd/kperf/commands/virtualcluster/nodepool.go
to call the newApplyPriorityLevelConfiguration
function.Documentation Improvements:
docs/getting-started.md
.docs/getting-started.md
to reflect current configurations and image versions. [1] [2]docs/runkperf.md
to reflect updated configurations and image versions. [1] [2] [3]Helm Chart Updates:
FlowSchema
inmanifests/runnergroup/server/templates/flowcontrol.yaml
andmanifests/virtualcluster/nodecontrollers/templates/flowcontrol.yaml
. [1] [2]