*: use two releases to deploy virtual nodes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuweid
force-pushed
the
weifu/render-node-after-kwok
branch
2 times, most recently
from
cd5c30e to
676e1ba
Compare
Some cloud providers will delete unknown or not-ready nodes. If we render both nodes and controllers in one helm release, helm won't wait for controller ready before creating nodes. The nodes will be deleted by cloud providers. ```bash $ kperf vc nodepool add xxx --nodes=200 ... 6s Normal RegisteredNode node/xxx-26 Node xxx-26 event: Registered Node xxx-26 in Controller 0s Normal DeletingNode node/xxx-110 Deleting node xxx-110 because it does not exist in the cloud provider 0s Normal DeletingNode node/xxx-139 Deleting node xxx-139 because it does not exist in the cloud provider 0s Normal DeletingNode node/xxx-175 Deleting node xxx-175 because it does not exist in the cloud provider 0s Normal DeletingNode node/xxx-162 Deleting node xxx-162 because it does not exist in the cloud provider ``` The helm's post-install or post-upgrade hook can ensure that it won't deploy nodes until controllers ready. However, resources created by helm hook aren't part of helm release. We need extra step to cleanup nodes resources when we delete nodepool's helm release. Based on this fact, we separate one helm release into two. One is for controllers and other one is for nodes. Signed-off-by: Wei Fu <[email protected]>
Signed-off-by: Wei Fu <[email protected]>
fuweid
force-pushed
the
weifu/render-node-after-kwok
branch
from
4637ce7 to
3720317
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cloud providers will delete unknown or not-ready nodes. If we render both nodes and controllers in one helm release, helm won't wait for controller ready before creating nodes. The nodes will be deleted by cloud providers.
The helm's post-install or post-upgrade hook can ensure that it won't deploy nodes until controllers ready. However, resources created by helm hook aren't part of helm release. We need extra step to cleanup nodes resources when we delete nodepool's helm release.
Based on this fact, we separate one helm release into two. One is for controllers and other one is for nodes.