Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding vc nodepool list command #73

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Adding vc nodepool list command #73

merged 1 commit into from
Jan 31, 2024

Conversation

manasachi
Copy link
Contributor

@manasachi manasachi commented Jan 30, 2024

Lists nodepool data from nodepools added from vc nodepool add command
image

@manasachi manasachi force-pushed the mchinta/nodepoolList branch 2 times, most recently from 7eba7ef to 787e75a Compare January 30, 2024 04:18
virtualcluster/node_list.go Outdated Show resolved Hide resolved
fmt.Println("No error :)")
fmt.Println("Number of nodepools: \n", len(nodepools))
fmt.Println()
for _, nodepool := range nodepools {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can consider to define a function to render a table, like

func renderRunnerGroups(rgs []*types.RunnerGroup) error {

@manasachi manasachi force-pushed the mchinta/nodepoolList branch 3 times, most recently from ca41bc8 to 787e75a Compare January 31, 2024 03:20
@manasachi manasachi closed this Jan 31, 2024
@manasachi manasachi force-pushed the mchinta/nodepoolList branch from afa0ec9 to b18eae3 Compare January 31, 2024 03:20
@manasachi manasachi reopened this Jan 31, 2024
@manasachi manasachi force-pushed the mchinta/nodepoolList branch from 9664461 to 6277412 Compare January 31, 2024 03:28
Copy link
Collaborator

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 9c17a2a into main Jan 31, 2024
4 checks passed
@fuweid fuweid deleted the mchinta/nodepoolList branch January 31, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants