Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor to maintain policy state in-memory #49

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
75b3f7d
maintain state of a placement policy in-memory rather than use pod an…
cmaclaughlin Jan 19, 2022
67eb90e
attempt to resolve issues
cmaclaughlin Jan 21, 2022
f457f74
initial PR changes
cmaclaughlin Jan 24, 2022
6d0aea4
fix compilation error
cmaclaughlin Jan 24, 2022
cba7a0c
Update pkg/plugins/placementpolicy/core/core.go
cmaclaughlin Feb 8, 2022
8059236
Update pkg/plugins/placementpolicy/core/policy.go
cmaclaughlin Feb 8, 2022
138af22
Merge branch 'Azure:main' into inmemory-policy-state
cmaclaughlin Feb 8, 2022
1f17889
changes per initial PR comments
cmaclaughlin Feb 8, 2022
744c441
Merge branch 'Azure:main' into inmemory-policy-state
cmaclaughlin Feb 22, 2022
f104ce5
adding comments for clarity
cmaclaughlin Feb 22, 2022
da2c4e6
Update pkg/plugins/placementpolicy/placementpolicy.go
cmaclaughlin Feb 25, 2022
8f418f9
Update pkg/plugins/placementpolicy/placementpolicy.go
cmaclaughlin Feb 25, 2022
db96728
Update pkg/plugins/placementpolicy/core/policy.go
cmaclaughlin Feb 25, 2022
cedd819
Update pkg/plugins/placementpolicy/core/policy.go
cmaclaughlin Feb 25, 2022
3adaed7
Update pkg/plugins/placementpolicy/core/policy.go
cmaclaughlin Feb 25, 2022
cd95269
Update pkg/plugins/placementpolicy/core/policy.go
cmaclaughlin Feb 25, 2022
0d482b2
Update pkg/plugins/placementpolicy/core/policy.go
cmaclaughlin Feb 25, 2022
34b0d77
Update pkg/plugins/placementpolicy/core/policy.go
cmaclaughlin Feb 25, 2022
c2fb51e
Update pkg/plugins/placementpolicy/core/policy.go
cmaclaughlin Feb 25, 2022
5f93723
Update pkg/plugins/placementpolicy/placementpolicy.go
cmaclaughlin Feb 25, 2022
e346776
initial changes for next round of feedback
cmaclaughlin Feb 25, 2022
ef85acc
Additional changes per PR feedback
cmaclaughlin Feb 25, 2022
934623e
remove stage dependency
cmaclaughlin Feb 25, 2022
d2fc5ef
final cleanup/fixes
cmaclaughlin Feb 25, 2022
0d7a9f3
Merge branch 'Azure:main' into inmemory-policy-state
cmaclaughlin May 5, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update pkg/plugins/placementpolicy/placementpolicy.go
Co-authored-by: Anish Ramasekar <[email protected]>
  • Loading branch information
cmaclaughlin and aramase authored Feb 25, 2022
commit 8f418f982b7a0c5ea7521f9ed909072eeab83cf2
2 changes: 1 addition & 1 deletion pkg/plugins/placementpolicy/placementpolicy.go
Original file line number Diff line number Diff line change
@@ -203,7 +203,7 @@ func (p *Plugin) PreScore(ctx context.Context, state *framework.CycleState, pod
return framework.NewStatus(framework.Error, "failed to cast state data")
}

//if pod has already been added to the policy in (Pre)Filter, don't need to do anything with scoring
// if pod has already been added to the policy in (Pre)Filter, don't need to do anything with scoring
if d.status == Added {
return framework.NewStatus(framework.Success, "")
}