Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix #890) Fix Undefined Error with No Subs in Azure Profile #892

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

Timothyw0
Copy link
Member

@Timothyw0 Timothyw0 commented Oct 17, 2024

Make the subscriptions property optional in AzureProfile since it may not exist as described in Issue #890.

Tested by removing subscriptions in my azureProfile.json and code will no longer throw an undefined error. Then the login will fallback to another means to authenticate.

@Timothyw0 Timothyw0 marked this pull request as ready for review October 17, 2024 13:57
@Timothyw0 Timothyw0 requested a review from cjk7989 as a code owner October 17, 2024 13:57
Copy link
Contributor

@cjk7989 cjk7989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems well-implemented for the described issue

@Timothyw0 Timothyw0 merged commit e941c77 into Azure:main Dec 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants