-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Day 0 - hook for Retina and Azure N/W Distributed Capture Scenarios with AKS VsCode Extension. #624
Conversation
@Tatsinnit It's fixed and v0.0.7 is released. |
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
Signed-off-by: Tatsat Mishra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Signed-off-by: Tatsat Mishra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this. Works as expected and looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested this, and also looked into the captures. The download capture works fine and able to save this locally. The downloaded capture has some crucial information that would help us in reducing the TTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested as well works fine in windows and WSL2 (linux). A minor name change suggestion. Thank you @Tatsinnit.
…ith AKS VsCode Extension. (Azure#624)
Description and Goal of this PR:
Thank you so much for all the cross collaboration for this and the quick loop back to fix various issues along the way across Retina et. al. Below are the Goal and Non-Goals and future representation of what we plan to achieve. Special mention to @gamntho and
Goal: This PR is solely focused in on enabling Retina Tool Distributed Capture Enablement which intern detail below enables various moving pieces under
one-click
umbrella, covering specific user-scenarios of #569 (comment) , proving ease to user and collecting log via Retina which helps for User Experiences. This PR is solely focus on short-term goal discussed under this feature request #569 which is closing the loop on #260Non-Goal: This PR is not the long term U/X based user-scenario work which we will do as part of internal PRD under which we need to identify the re-use or removing certain exisiting features incrementally. If we need to rethink U/X from various stand point of view along with possible reachout to vscode team to get their guidance if need be.
This PR enables a key aspect of Network loop which we wanted to close before we solely focus on upgrading and maintaining those
What we achieve:
This PR bundles few things into one:
Under
one-click
:User will navigate to their cluster and right-click select
network troubleshooting menu
submenuRun Retina Capture
OK
the vscode heavy-lifting at the background will start, it will wait for https://retina.sh/docs/captures/cli#capture-targetrequiredcapture network packets on the node selected by node names
which will kick in.Get the Retina logs to Host Machine:
Hence doing all these things with ease, this is not perfect and we will incrementally improve but providing this baseline really will enable users to cover the Azure N/W Log captures via vscode.
Screenshot below is a quick recap:
Collaboration:
--Kubeconfig
Flag doesn't work with Retina Create microsoft/retina#258 Kudos to Evan, Prabha, Vamsi for this collaboration. Thank you so much to Hari for helping the U/X side of things.Future:
VSIX to test:
Screenshots:
Screen.Recording.2024-04-16.at.6.24.28.PM.mov