Skip to content

Commit

Permalink
Xw/clean parcels mess (#2238)
Browse files Browse the repository at this point in the history
* fix: appease docker warnings

* chore: use last fix of node v20

* fix: use typeScript notation that parcel can handle

* feat: comment explaining longer notation
  • Loading branch information
kilted-andres authored Dec 11, 2024
1 parent a3328ef commit 3a5a993
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:20.15.1-alpine AS base
FROM node:20.18.1-alpine AS base

WORKDIR /app

Expand Down Expand Up @@ -28,8 +28,8 @@ RUN apk add --update --no-cache nginx nginx-mod-http-brotli
COPY ./nginx.conf /etc/nginx/http.d/default.conf

# tell the app it will run on port 4000 in production mode
ENV PORT 4000
ENV NODE_ENV production
ENV PORT=4000
ENV NODE_ENV=production

# get the dependencies and sources
COPY package.json yarn.lock .yarnrc.yml ./
Expand All @@ -41,4 +41,4 @@ RUN yarn install --immutable && yarn cache clean --all
COPY --from=builder /app/dist dist

EXPOSE 3000
ENTRYPOINT nginx; exec yarn start
ENTRYPOINT [ "sh", "-c", "nginx && exec yarn start" ]
4 changes: 3 additions & 1 deletion src/backend/revoker/indexer/queryAttestations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ async function* attestationParser(
const revoked =
removalBlock !== null ? null : revocationBlock !== null ? true : false;

yield <AttestationInfo>{
const parsedAttestation: AttestationInfo = {
owner: issuerId,
claimHash,
cTypeHash,
Expand All @@ -129,5 +129,7 @@ async function* attestationParser(
block: blockNumber,
createdAt,
};
// trying to yield directly with `<AttestationInfo>` breaks parcel
yield parsedAttestation;
}
}

0 comments on commit 3a5a993

Please sign in to comment.