New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard against missing animation data #29

Merged

Palmer-JC merged 1 commit into BabylonJS:master from ghempton:fix-npe

Oct 10, 2020

Contributor

ghempton commented Oct 6, 2020 •

edited

Loading

For a mesh with an armature and no animations, the export currently fails. This PR fixes this. This was my bad and introduced by my previous PR.

Not sure if related to #26 or #27


          Guard against missing animation data

17f8e73

Collaborator

Palmer-JC commented Oct 7, 2020

Thanks. I think it is was related to another PR, 27520a0#diff-711dfe633e475a6b6ede53b3a5668313

They put the line in a place where it only worked when there was an animation. Will merge this tomorrow.

Palmer-JC merged commit 2f7aa46 into BabylonJS:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet