Skip to content

Commit

Permalink
remove not required quote as it renders as code
Browse files Browse the repository at this point in the history
  • Loading branch information
@harsh-julka-bb
harsh-julka-bb committed Dec 1, 2023
1 parent 169268b commit 8561130
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion _posts/2023-11-14-setup-microfrontend.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ Let's see four different ways to share theming between shell and remote applicat

**Solution**: Based on above illustration, the most efficient approach for maintaining consistent CSS is to implement global shared theme.

Check warning on line 241 in _posts/2023-11-14-setup-microfrontend.md

View workflow job for this annotation

GitHub Actions / vale

[vale] _posts/2023-11-14-setup-microfrontend.md#L241 

[Google.Colons] ': B' should be in lowercase.
Raw output 
{"message": "[Google.Colons] ': B' should be in lowercase.", "location": {"path": "_posts/2023-11-14-setup-microfrontend.md", "range": {"start": {"line": 241, "column": 13}}}, "severity": "WARNING"}

Check warning on line 241 in _posts/2023-11-14-setup-microfrontend.md

View workflow job for this annotation

GitHub Actions / vale

[vale] _posts/2023-11-14-setup-microfrontend.md#L241 

[Google.WordList] Use 'preceding' instead of 'above'.
Raw output 
{"message": "[Google.WordList] Use 'preceding' instead of 'above'.", "location": {"path": "_posts/2023-11-14-setup-microfrontend.md", "range": {"start": {"line": 241, "column": 24}}}, "severity": "WARNING"}

Check warning on line 241 in _posts/2023-11-14-setup-microfrontend.md

View workflow job for this annotation

GitHub Actions / vale

[vale] _posts/2023-11-14-setup-microfrontend.md#L241 

[write-good.TooWordy] 'implement' is too wordy.
Raw output 
{"message": "[write-good.TooWordy] 'implement' is too wordy.", "location": {"path": "_posts/2023-11-14-setup-microfrontend.md", "range": {"start": {"line": 241, "column": 109}}}, "severity": "WARNING"}

`A shared global theme or at shell only is the only possible way to do styling in micro frontends. Also, we only considered` <a href="https://www.npmjs.com/package/@angular-architects/module-federation#which-version-to-use" target="_blank">ITCSS architecture</a> `for this POC and haven't explored component-level styling.`
A shared global theme or at shell only is the only possible way to do styling in micro frontends. Also, we only considered <a href="https://www.npmjs.com/package/@angular-architects/module-federation#which-version-to-use" target="_blank">ITCSS architecture</a> for this POC and haven't explored component-level styling.

Check warning on line 243 in _posts/2023-11-14-setup-microfrontend.md

View workflow job for this annotation

GitHub Actions / vale

[vale] _posts/2023-11-14-setup-microfrontend.md#L243 

[write-good.Weasel] 'only' is a weasel word!
Raw output 
{"message": "[write-good.Weasel] 'only' is a weasel word!", "location": {"path": "_posts/2023-11-14-setup-microfrontend.md", "range": {"start": {"line": 243, "column": 35}}}, "severity": "WARNING"}

Check warning on line 243 in _posts/2023-11-14-setup-microfrontend.md

View workflow job for this annotation

GitHub Actions / vale

[vale] _posts/2023-11-14-setup-microfrontend.md#L243 

[write-good.Weasel] 'only' is a weasel word!
Raw output 
{"message": "[write-good.Weasel] 'only' is a weasel word!", "location": {"path": "_posts/2023-11-14-setup-microfrontend.md", "range": {"start": {"line": 243, "column": 47}}}, "severity": "WARNING"}

Check warning on line 243 in _posts/2023-11-14-setup-microfrontend.md

View workflow job for this annotation

GitHub Actions / vale

[vale] _posts/2023-11-14-setup-microfrontend.md#L243 

[Google.We] Try to avoid using first-person plural like 'we'.
Raw output 
{"message": "[Google.We] Try to avoid using first-person plural like 'we'.", "location": {"path": "_posts/2023-11-14-setup-microfrontend.md", "range": {"start": {"line": 243, "column": 105}}}, "severity": "WARNING"}

Check warning on line 243 in _posts/2023-11-14-setup-microfrontend.md

View workflow job for this annotation

GitHub Actions / vale

[vale] _posts/2023-11-14-setup-microfrontend.md#L243 

[write-good.Weasel] 'only' is a weasel word!
Raw output 
{"message": "[write-good.Weasel] 'only' is a weasel word!", "location": {"path": "_posts/2023-11-14-setup-microfrontend.md", "range": {"start": {"line": 243, "column": 108}}}, "severity": "WARNING"}


**Duplicate Source Code**
Expand Down

0 comments on commit 8561130

Please sign in to comment.