Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

post: angular unit testing with spectator #65

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

allhandsondeck
Copy link
Contributor

@allhandsondeck allhandsondeck commented Aug 8, 2023

What is this article about?

R: Angular unit testing with spectator

Checklist:

  • I am added to the list of authors correctly.
  • All images used in the post is in the correct folder (assets/images/post/).
  • My article has been reviewed internally before opening this Pull Request.
  • I have not modified someone else's previously published articles.
  • I double checked my changes locally at http://127.0.0.1:4000/ after running bundle install && bundle exec jekyll serve.
  • My changes generate no new errors

@allhandsondeck allhandsondeck force-pushed the post/angular-unit-testing-with-spectator branch from b9acfc0 to 1f61a16 Compare October 23, 2023 18:30
@allhandsondeck
Copy link
Contributor Author

Not sure why Linting fails but there is no errors, just warnings in the vale output:
Screenshot 2023-10-23 at 20 41 23

@arthurpalves
Copy link
Member

Not sure why Linting fails but there is no errors, just warnings in the vale output:

Screenshot 2023-10-23 at 20 41 23

The issue isn't related to your content, it is related to this errata-ai/vale-action#108

We should investigate but for now you can ignore, we can merge it with the right approvals.

@robinsonzimmermann
Copy link
Member

@allhandsondeck feel free to rename you md file to a later date to get it published on top. Other than that, looks good to me

@allhandsondeck allhandsondeck force-pushed the post/angular-unit-testing-with-spectator branch from cedfb0b to 3fb9caa Compare October 27, 2023 09:26
@allhandsondeck allhandsondeck merged commit 9542b88 into main Oct 27, 2023
2 of 3 checks passed
@allhandsondeck allhandsondeck deleted the post/angular-unit-testing-with-spectator branch October 27, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants